feat: Add Mentions to draft messages #WPB-12062 #3687
Conversation
borichellow
requested review from
m-zagorski,
yamilmedina,
Garzas and
saleniuk
echoes-hq
bot
added
the
echoes: product-roadmap
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3687 +/- ##
===========================================
- Coverage 45.57% 45.56% -0.01%
===========================================
Files 476 476
Lines 16105 16108 +3
Branches 2736 2736
===========================================
Hits 7340 7340
- Misses 7998 8001 +3
Partials 767 767
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3687.apk is available for download |
|
Built wire-android-dev-debug-pr-3687.apk is available for download |
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt
Outdated
Show resolved
Hide resolved
|
Built wire-android-staging-compat-pr-3687.apk is available for download |
|
Built wire-android-dev-debug-pr-3687.apk is available for download |
| ) | ||
| } | ||
|
|
||
| if (draftMessageComposition.selectedMentions.isNotEmpty()) { |
There was a problem hiding this comment.
question: shouldn't that have its own LaunchedEffect to be executed every time when draftMessageComposition.selectedMentions changes? 🤔
There was a problem hiding this comment.
that is not necessary so far, as selectedMentions is updated only with draftText (in MessageDraftViewModel.loadMessageDraft())
|
please only merge in 4.11 |
|
Built wire-android-staging-compat-pr-3687.apk is available for download |
|
Built wire-android-dev-debug-pr-3687.apk is available for download |
yamilmedina
dismissed
MohamadJaara’s stale review
After the switcharoo, we can merge to develop already
|
|
Built wire-android-staging-compat-pr-3687.apk is available for download |
|
Built wire-android-dev-debug-pr-3687.apk is available for download |
Co-authored-by: Yamil Medina <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
What's new in this PR?
Issues
As a user when I type a message that have a mention and i go back to the conversation later to send the draft it should be sent with the mention.
Causes (Optional)
Mentions are saved in draft but never used.
Solutions
Check if draft contains mentions and use it if so